search

emacs-lsp / lsp-ui

UI integrations for lsp-mode
https://emacs-lsp.github.io/lsp-ui
GNU General Public License v3.0
1.03k stars 141 forks source link

Also bind "<tab>" in addition to "TAB" for lsp-ui-peek #686

Closed futile closed 2 years ago

futile commented 2 years ago

When "<tab>" (which is the same as [tab] I believe) is not bound in lsp-ui-peek-mode-map, other keymaps that bind "<tab>" can grab a Tab-key press before it is handled as "TAB" by lsp-ui-peek. Therefore, also bind to "<tab>"/[tab] so that the key is always handled by lsp-ui-peek when the peek-window is open. This should only make a difference in GUI emacs, as console emacs can/does not differentiate between "<tab>" and "TAB".

I originally discovered & reported this in doom-emacs, and the fix given here is basically what doom's maintainer recommended, see the (short) bug report here: https://github.com/hlissner/doom-emacs/issues/5028

Disclosure: I only tested the doom-version of the bugfix given in the bug report linked above, and it fixed the issue. I did not test this PR locally; I'm relying on CI/reviews to make sure nothing breaks, as this looks like a small change to me.

futile commented 2 years ago

Thanks for the quick feedback! I see that (at least) one CI job is failing, but I can't really interpret the output that is given. Does this look like a failure related to this PR? In that case I'll start debugging this locally.

brotzeit commented 2 years ago

There's currently an issue with emacs snapshot and cask.

futile commented 2 years ago

Alright, thanks for the super quick feedback & merge! Very appreciated! :)