Move triggering of lsp-ui-doc auto-hide to after display

emacs-lsp / lsp-ui

UI integrations for lsp-mode

https://emacs-lsp.github.io/lsp-ui

GNU General Public License v3.0

1.03k stars 141 forks source link

Move triggering of lsp-ui-doc auto-hide to after display #696

Closed Lenbok closed 2 years ago

Lenbok commented 2 years ago

This is my attempt to address #695.

As well fixing auto-hide for docs explicitly invoked via lsp-ui-doc-glance, this adds post-command clearing to both lsp-ui-doc-show-with-mouse and lsp-ui-doc-show-with-cursor. That seems consistent to me, so I don't think it presents a problem.

Maybe there should be a separate lsp-ui-doc-auto-hide setting to disable auto-hiding for all three of these mechanisms?

Fixes: #695

Lenbok commented 2 years ago

@yyoncho @ericdallo Would you be able to review this fix?

Lenbok commented 2 years ago

(rebased to master)

Lenbok commented 2 years ago

@yyoncho @jcs090218 Is someone able to review / merge this?

jcs090218 commented 2 years ago

Thanks!