emacs-lsp / lsp-ui

UI integrations for lsp-mode
https://emacs-lsp.github.io/lsp-ui
GNU General Public License v3.0
1.03k stars 141 forks source link

Cannot see or run code actions for haskell #724

Closed samuelrivas closed 1 year ago

samuelrivas commented 1 year ago

After upgrading to the latest version of lsp-ui, code actions don't work for haskell (I have not checked with any other language).

Before updating I see this

working

After updating I see this

not-working

Furthermore, running lsp-ui-sideline-apply-code-actions shows "No code actions on the current line" on the minibuffer.

Additionally, the ui is not showing the frame with type and documentation info when moving the cursor onto a function:

Before update:

working-ui

After update:

not-working-ui

LSP :: Connected to [lsp-haskell:408067/starting].
Starting new Ispell process /nix/store/nvm9cy7d5slpqnjjgdal7nflg9i5bdrl-emacs-packages-deps/bin/aspell with default dictionary...done
LSP :: lsp-haskell:408067 initialized successfully in folders: (/home/samuel.rivas/src/monorepos/sams-monorepo/src/haskell/monad-emit/src/src)
Invalid face reference: lsp-flycheck-warning-unnecessary [8 times]

There is some extra context in the issue I initially opened for haskell-language-server

samuelrivas commented 1 year ago

Nevermind, I found it

https://github.com/emacs-lsp/lsp-ui/commit/f3917a87bfc5c556055e5c7cb8c3e5944344e6ee#diff-3152e0c23d81015ff9ef8152d49c4e6dbf55733a1200fb56557f1bb7b0133f37L80

Seems that sdieline actions need to be enabled explicitly since the version just after the one I had.