search

emacs-lsp / lsp-ui

UI integrations for lsp-mode
https://emacs-lsp.github.io/lsp-ui
GNU General Public License v3.0
1.03k stars 141 forks source link

fix(ui-doc): Hide doc frame on next post command #775

Closed jcs090218 closed 2 months ago

brownts commented 2 months ago

Hi @jcs090218, I'm seeing some odd behavior that seems to be related to this commit. In the past, I've been able to move the mouse pointer over the child frame and use the mouse wheel to scroll the child frame. Now, it appears as soon as I move the mouse pointer, the child frame disappears, so I can't scroll the child frame at all anymore. This worked either with lsp-ui-doc-show-with-cursor or with lsp-ui-doc-show-with-mouse. Can this capability be restored?

Another oddity appears to be the alternation of the child frame being displayed or hidden. I believe this happens both with mouse and cursor hover settings (i.e., lsp-ui-doc-show-with-mouse and lsp-ui-doc-show-with-cursor respectively), but is most prominent with the cursor hover setting. In that configuration, it's easy to see the problem. If point is over a word that causes the child frame to be displayed, each time I move the point (for example starting at the left of the word and moving right one character at a time), the child frame will alternate between being displayed and not being displayed. In the past, the child frame would stay displayed the entire time (possibly repositioning if lsp-ui-doc-position was set to at-point) as the point was moved to the right.

jcs090218 commented 2 months ago

I'll take a look!

brownts commented 1 month ago

Looks like someone else is having a similar problem related to this change:

hellified commented 1 month ago

Yep, that's my cry for help on Reddit. I'll watch here for further developments. Super annoying to lose the ability to click the link in the box and pop open the browser with full docs.

I can volunteer to be a guinea pig for changes if that will help.

If there is an existing issue I can follow please let me know. I won't open one right away as you've already stated you're looking into it.

jcs090218 commented 1 month ago

Sorry, I was a little busy. I'll take a look tomorrow!

jcs090218 commented 1 month ago

I've reverted the changes!