Properly provide and require test-helper

emacs-lsp / lsp-ui

UI integrations for lsp-mode

https://emacs-lsp.github.io/lsp-ui

GNU General Public License v3.0

1.03k stars 141 forks source link

Properly provide and require test-helper #779

Closed manphiz closed 1 month ago

manphiz commented 1 month ago

This ensures that tests have access to the helper functions defined in test/test-helper.el.

jcs090218 commented 1 month ago

test-helper.el is loaded by default using ert-runner. 🤔

manphiz commented 1 month ago

Ah, this is mostly useful for distribution that doesn't have/use eask, e.g. Debian. We have a custom script that directly run ert tests, in which case adding a proper provide/require will help.

jcs090218 commented 1 month ago

Ah, this is mostly useful for distribution that doesn't have/use eask, e.g. Debian. We have a custom script that directly run ert tests, in which case adding a proper provide/require will help.

See https://github.com/jcs-elpa/reveal-in-folder/issues/3#issue-784460807.

manphiz commented 1 month ago

AIUI, test/test-helper.el is not a test file per se, but a library/helper for tests, so I don't think it should be prevented to use provide. For other actual test files (with ert-deftest) the suggestion apply, of course.

jcs090218 commented 1 month ago

This test is intended to be used with ert-runner, and since test-helper.el will be loaded by default, I’m sorry, but I don't see the need to merge this. 🤔 😅

manphiz commented 1 month ago

Fair enough :) It's OK. I will carry a patch to cope with the restrictions in Debian. Thanks!

jcs090218 commented 1 month ago

Thank you for understanding! :)