search

emacs-php / php-mode

A powerful and flexible Emacs major mode for editing PHP scripts
GNU General Public License v3.0
583 stars 118 forks source link

Symbol highlight #438

Open ilyaguy opened 6 years ago

ilyaguy commented 6 years ago

I've started using highlight-symbol package. When I turn on hl-s-mode, it highlights only function names and strings, but no variables. At the same time, when I use highlight-symbol-next command it works fine: navigate me through variables too. test php script

ilyaguy commented 6 years ago

Link to the same issue on hl-s: https://github.com/nschum/highlight-symbol.el/issues/46

mikej96 commented 6 years ago

I've had a similar as well for some time (using idle-highlight-mode) and the issue seems to be related to php-mode. (No other modes are affected that I have discovered.)

Steps to reproduce, run emacs -Q, open a php file, move point to a local variable (not an object property), and run M-x highlight-symbol-at-point. Notice the symbol does not highlight.

Attached is a screenshot that shows this happening with the variable named $workers. Some things do highlight, like comments, and function names, but not the actual variable.

screenshot_2018-10-09_10-07-57