search

emacs-php / php-mode

A powerful and flexible Emacs major mode for editing PHP scripts
GNU General Public License v3.0
583 stars 118 forks source link

Properly list the credits of all previous contributors #687

Closed zonuexe closed 2 years ago

zonuexe commented 2 years ago

Fixed many omissions that occurred when separating the contributor list from the README.md to AUTHORS.md.

refs https://github.com/emacs-php/php-mode/issues/685, fixes https://github.com/emacs-php/php-mode/pull/607 and closes https://github.com/emacs-php/php-mode/pull/686. Thanks to @Shamar for reporting this issue.

Shamar commented 2 years ago

You are wellcome @zonuexe, thanks for adding back our names. While it has been a while since I last opened Emacs, I'm still proud of my contribution to php-mode from when I were younger (back in the 2004, I did the port/rewrite of php-mode when PHP5 introduced object orientation: Emacs was the first free software editor to support the new language features!)

Since I'm here: would you mind to add a link to my website in the Wiki (I'm Giacomo Tesio)? I've seen others have their GitHub account linked, but I'm going to leave as soon as I will have found a new home for Jehanne

zonuexe commented 2 years ago

@Shamar Thank you! I added link to your web site. https://github.com/emacs-php/php-mode/wiki/Authors/_history

zonuexe commented 2 years ago

This is completely off-topic, but my mother's hometown is an area called Teshio. The pronunciation is a little different, but it sounds a little unusual for Japanese, so I feel a little nostalgic. 😄