search

emacs-php / php-mode

A powerful and flexible Emacs major mode for editing PHP scripts
GNU General Public License v3.0
580 stars 118 forks source link

Minor readme fixes #759

Closed sten0 closed 10 months ago

sten0 commented 10 months ago

Just some small things I noticed

sten0 commented 10 months ago

gah, kept missing those links at the end...

NateEag commented 10 months ago

Oh, good catches - thanks @sten0 !

Are current Debian and Ubuntu packages up-to-date? Just want to be sure we won't have similar difficulties of doing support for out-of-date versions if we remove those warnings instead of updating them.

sten0 commented 10 months ago

Nate Eagleson @.***> writes:

Oh, good catches - thanks @sten0 !

You're welcome!

Are current Debian and Ubuntu packages up-to-date? Just want to be sure we won't have similar difficulties of doing support for out-of-date versions if we remove those warnings instead of updating them.

Debian unstable/sid has 1.25.0, and stable/bookworm (aka: Debian 12) has 1.24.2. You don't need to support 1.24.2, of course. Debian stable is sometimes called "Debian stale", and this well known feature is also valued because it's mature and rigorously tested rather than cutting edge software. And yes, if ever a serious bug was found in php-mode 1.24.2 (ie anything that makes it nonviable) then targeted fixes are encouraged. It would surprise me if that happened, because every release has at least six months of fuzzing where a package is dropped from a release if it has a serious unfixed bug.

A method for installing the version from unstable/sid (the latest available version) onto any release (Debian or Ubuntu) is already documented in this README.

The paragraph I've deleted refers to unsupported releases from 2017...You can keep this paragraph if you want, but I hope you see the irony of out-of-date documentation condemning "out-of-date versions". The documentation will become out of date again, thus I recommend just deleting it. I wasn't involved with php-mode for Debian 9 (stretch), btw, and only started looking after it in 2018.

NateEag commented 10 months ago

Thanks very much for the info!

I think that paragraph definitely needs updating, and appreciate you pointing it out.

I'm just not sure whether complete removal or regular updating is the best approach.

zonuexe commented 10 months ago

Thank you all!

sten0 commented 10 months ago

@sten0 - yup, you're right - I obviously misread that. Good point, sorry about that.

No worries! Thank you for taking the time to review and discuss this PR

sten0 commented 10 months ago

It's been a year since Debian 9 Stretch EOL, so it seems that few people are confused anymore. :+1:

Haha, yes, this is a much more succinct explanation :)

Thanks for merging!