search

emacs-php / php-mode

A powerful and flexible Emacs major mode for editing PHP scripts
GNU General Public License v3.0
580 stars 118 forks source link

ci: Build with Eask #762

Closed jcs090218 closed 9 months ago

jcs090218 commented 9 months ago

CI improvements! :)

zonuexe commented 9 months ago

@jcs090218 Thank you, I want to see Eask in action right away, so I merge this 😄

zonuexe commented 9 months ago

https://github.com/emacs-php/php-mode/actions/runs/6166874224

windows-latest tends to fail, so maybe we should tolerate failure. Also, macos-* is also a little slow, so it might be a good idea to build only 28.2, 29.1, and snapshot. I have older Emacs provided by my linux package manager so I'm testing them, but I believe macOS users are using newer Emacs.

jcs090218 commented 9 months ago

windows-latest tends to fail, so maybe we should tolerate failure.

Isn't the experimental flag enough? 🤔 The mark will still be red ❌, but the badge will be green CI.

Also, macos-* is also a little slow, so it might be a good idea to build only 28.2, 29.1, and snapshot.

I really like the way it acts now. It feels so consistent. 😁

I have older Emacs provided by my linux package manager so I'm testing them, but I believe macOS users are using newer Emacs.

Doesn't "manual testing" defeat the purpose of using CI/CD? 🤔 I mean I'll just let the machine run on its own! ;)

zonuexe commented 9 months ago

Isn't the experimental flag enough? 🤔 The mark will still be red ❌, but the badge will be green CI.

👍