search

emacs-php / php-mode

A powerful and flexible Emacs major mode for editing PHP scripts
GNU General Public License v3.0
580 stars 118 forks source link

On Emacs >= 29.1, `php-function-call` face inherits from `font-lock-function-call-face` #783

Closed bricka closed 2 weeks ago

bricka commented 2 weeks ago

Resolves #782

zonuexe commented 2 weeks ago

@bricka Your change is very reasonable, and I thought last night that this change was enough. However, I am concerned that it will cause cognitive friction, because the difference from the existing display is large depending on the theme used by the user. Therefore, I proposed a new face and an opt-in variable to switch to the "-standard" face in #784.

I'm sorry, but I would like to merge #784 instead of this PR, and rest assured that your contribution is recorded in that branch as well. Your contribution is very much appreciated!