emacs-php / php-mode

A powerful and flexible Emacs major mode for editing PHP scripts
GNU General Public License v3.0
580 stars 118 forks source link

Add `font-lock-function-call` compatible faces #784

Closed zonuexe closed 2 weeks ago

zonuexe commented 2 weeks ago

The font-lock-function-call face has been added in Emacs 29.1. It is reasonable for php-function-call to inherit this face, but it has a large visual impact on existing users. This PR introduces faces with -traditional and -standard suffixes.

To make it easier for users to switch between these faces, the php-function-call, php-method-call and php-static-method-call custom variables have been added. You can set these to switch to a different face individually. These variables point to the traditional face by default.

If you want to change the face, add these lines to your init.el.

(with-eval-after-load 'php
  (setopt php-function-call 'php-function-call-standard)
  (setopt php-method-call 'php-method-call-standard)
  (setopt php-static-method-call 'php-static-method-call-standard))

refs #782, #783, thanks to @bricka

zonuexe commented 2 weeks ago

@bricka If you have any comments about these changes, please let us know.

bricka commented 2 weeks ago

Sorry for the delay: looks good to me! We might consider updating the README to mention these as well.

zonuexe commented 2 weeks ago

@bricka Thank you for your cooperation!