Preparing for the release of php-ts-mode

emacs-php / php-ts-mode

A Tree-sitter based major mode for editing PHP codes

GNU General Public License v3.0

23 stars 8 forks source link

Preparing for the release of php-ts-mode #38

Open zonuexe opened 1 year ago

zonuexe commented 1 year ago

Organize TODOs for submitting php-ts-mode package to GNU ELPA.

[x] https://github.com/emacs-php/php-ts-mode/issues/39

EliphazBouye commented 10 months ago

What important things to do for php-ts-mode work?

akirak commented 5 months ago

GNU Emacs is about to ship a library with the same name (i.e. php-ts-mode) which is written by a different person named Vincenzo Pupillo:

https://mail.gnu.org/archive/html/bug-gnu-emacs/2024-06/msg00294.html

It's already in the master branch. It seems to contain more code (1654 lines) than the source file in this repository, but I don't know if it is better in features/quality. What will you do?

piotrkwiecinski commented 5 months ago

I mentioned it in https://github.com/emacs-php/php-ts-mode/pull/71#issuecomment-2181411016.

It's already ie emacs master and it's more feature complete than what we have.

It already includes support for:

multiple php coding styles
highlights for phpdoc,css,js in php files
php lint integration for flymake
built-in php server support

I reckon it would be the best to deprecate this repo and point people to the core and send patches to Emacs directly.

We could start with porting indentation tests from this repo.