emacs-php / php-ts-mode

A Tree-sitter based major mode for editing PHP codes
GNU General Public License v3.0
20 stars 8 forks source link

Add php-ts to PHP support from external packages #55

Closed zonuexe closed 4 months ago

zonuexe commented 8 months ago

While not blocking the release of php-ts-mode even if these supports are not merged, it would be ideal if they were available out-of-box for those who will try them when php-ts-mode is released, migrating from PHP Mode.

piotrkwiecinski commented 8 months ago

Eglot would require changes as well https://github.com/emacs-mirror/emacs/blob/master/lisp/progmodes/eglot.el#L245-L249 . I believe it'll require sending patch to the emacs core.

It's a 1 line. I haven't pushed any patches to the core. I'll give it a go at the end of the week.

zonuexe commented 8 months ago

I've sent PRs to most of the packages hosted on GitHub that are currently in active development. If you find any Lisp packages that are not supported, please feel free to comment.

piotrkwiecinski commented 8 months ago

@zonuexe eglot updated and submitted https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68870

zonuexe commented 8 months ago

@piotrkwiecinski Thanks! That commit has already been merged, so it should be reflected in the next Emacs 29 release and elgot package.

piotrkwiecinski commented 4 months ago
piotrkwiecinski commented 4 months ago

I'm going to close this ticket. If we need to track other integrations these can be tracked in separate tickets.