search

emacs-sideline / sideline

Show information on the side
GNU General Public License v3.0
118 stars 14 forks source link

String width calculation #23

Closed seagle0128 closed 3 months ago

seagle0128 commented 3 months ago

string-pixel-width is available in 29.x now.

https://github.com/emacs-sideline/sideline/blob/6ffa1b1accdd78d8a118061c851f5d40b228844c/sideline.el#L250-L265

Should consider the face (e.g. :height) while calculating the font width.

https://github.com/emacs-sideline/sideline/blob/6ffa1b1accdd78d8a118061c851f5d40b228844c/sideline.el#L267-L269

jcs090218 commented 3 months ago

string-pixel-width is available in 29.x now.

We have our own string-pixel-width due to this issue https://github.com/emacs-sideline/sideline/pull/21.

Should consider the face (e.g. :height) while calculating the font width.

Can you elaborate? 🤔

seagle0128 commented 3 months ago

We have our own string-pixel-width due to this issue #21.

OK. So the TODO in comments can be removed.

Can you elaborate? 🤔

I checked again, and seems the new solution will impact the performance. I'm closing it for now.