Closed ginqi7 closed 1 year ago
Nice package! A few thoughts:
sideline-eldoc-backend
to just sideline-eldoc
, word "backend" seems to be unnecessaryadvice-add
at the top level is generally not good, I might create a function for it! See sideline-flycheck for references.defgroup
, and mark defcustom
variables with itDo you plan to publish the package to MELPA? You might get a detailed review there. In terms of sideline
, I don't see huge problems. Great job! 👍 :D
(If you want, you can open a PR to add this package to https://github.com/emacs-sideline/sideline#-example-projects.)
Thank you for your patience and your advice. I will refine my code.
I have no experience publishing packages to MELPA; I like to study it.
Thank you very much for your project. It can effectively use the blank space of the display.
So I added a backend to eldoc:
https://github.com/ginqi7/sideline-eldoc
It looks like:
If you have time, I hope to receive your opinion.
Thanks.