search

emacs-tree-sitter / elisp-tree-sitter

Emacs Lisp bindings for tree-sitter
https://emacs-tree-sitter.github.io
MIT License
822 stars 74 forks source link

Add csharp highlight query #105

Closed jcs090218 closed 3 years ago

theothornhill commented 3 years ago

Should these queries be maintained in two places? Not sure I understand the rationale here. Why not contribute your additions to csharp-mode?

ubolonton commented 3 years ago

The queries bundled by tree-sitter-langs are for packages that are not tree-sitter-aware. csharp-mode is, so queries contributions for C# should go there.

jcs090218 commented 3 years ago

Got it! Thanks!

jcs090218 commented 3 years ago

@ubolonton I got one question here. Do you mean csharp-mode or csharp-tree-sitter-mode? csharp-mode doesn't aware of tree-sitter, but only csharp-tree-sitter-mode does (they both are major mode).

ubolonton commented 3 years ago

I mean the package, not the individual major modes.