search

emacs-twist / twist.nix

Build an entire Emacs configuration as a Nix package in a pure, reproducible way
GNU General Public License v3.0
66 stars 6 forks source link

Should parser be case-insensitive? #63

Closed terlar closed 1 year ago

terlar commented 1 year ago

I ran into the dired-hacks packages using Package-requires: instead of Package-Requires: and because of that the dependency resolution didn't work.

I created a PR to fix this: https://github.com/Fuco1/dired-hacks/pull/194/files

But perhaps the parser should be case-insensitive?

akirak commented 1 year ago

The manual doesn't explicitly state about case-sensitiveness, but lisp-mnt.el, which is used by package.el, performs search with case-fold-search set to t. For compatibility with the existing ecosystem for Emacs, it will be better to follow the implementation.

~I personally didn't want this change, because Nix's builtins.match supports no option. It will be done in a tedious (and ugly) way like [Pp][Aa][Cc][Kk][Aa][Gg][Ee]-[Rr][Ee][Qq][Uu][Ii][Rr][Ee][Ss]. But we should do it.~ I will make the change. Thanks.