search

emacs-typescript / typescript.el

TypeScript-support for Emacs
GNU General Public License v3.0
266 stars 79 forks source link

Bump Version Tag #151

Closed phikal closed 2 years ago

phikal commented 3 years ago

Hi,

I wanted to add typescript-mode to NonGNU ELPA, but it seems that typescript-mode.el has not bumped it's version tag despite two subsequent releases since 0.1 (this is relevant because ELPA uses the commit that bumps the version to mark releases). Would it be possible to update this, and if you are interested in having typescript-mode on NonGNU ELPA maintaining it for subsequent releases?

josteink commented 3 years ago

Hey Philip.

I don't have any problem with typescript-mode being published on NonGNU ELPA, but as many other MELPA-hosted packages typescript-mode is developed using a master-based release-mechanism. I.e., the latest version available always represents the current code in git master.

We sometimes tag versions for the sake of MELPA stable, but it's currently not done very consequently on consistently, so chances are users of MELPA Stable will have a fairly old version. If NonGNU ELPA also expects tagged/versioned releases, it will probably suffer the same fate.

Now by any means tagging isn't hard, it's just not a habit we have. Is that going to be a problem for NonGNU ELPA?

phikal commented 3 years ago

NonGNU ELPA distributes tagged versions by default, but the tagging can be done manually too. I have done so for now, but to avoid manual updates it is naturally preferable to bump the version tag whenever a release is made.

My hope is that since NonGNU ELPA will be enabled by default from Emacs 28.1 onwards, that the interest in publishing tagged versions will increase.

josteink commented 3 years ago

I just pushed the v0.4 tag right now.

Hopefully that should make things slightly more up to date :)

phikal commented 3 years ago

The only thing missing now for NonGNU ELPA is updating the version attribute in the package header. It shouldn't matter that the v0.4 tag doesn't point to the bump-commit.

josteink commented 3 years ago

Done!

phikal commented 3 years ago

Great, I'll add the package then in the next batch, then update this thread in case you want to update your documentation and add an ELPA badge.

theothornhill commented 2 years ago

Hi!

It seems typescript-mode never was added to nongnu elpa, is that so? What is missing to include it?

phikal commented 2 years ago

Nothing, I had just lost track of it. Sorry for the long delay, I have added it now: http://elpa.nongnu.org/nongnu/typescript-mode.html (as of writing the page is broken, but this will change as soon as the cron job updates the archive).