emacs-typescript / typescript.el

TypeScript-support for Emacs
GNU General Public License v3.0
266 stars 80 forks source link

Comint regexps are incorrect(?) #191

Open JordanAnthonyKing opened 1 month ago

JordanAnthonyKing commented 1 month ago

Comint mode includes the 'Error: ' part of the message in the path when trying to navigate to the file meaning that the file can't be automatically opened, and must be browsed to manually. This is running an npm build.

image

I've verified that only typescript related regexps are present in compilation-error-regexp-alist-alist

image

josteink commented 1 month ago

Hey there and thanks for the bug-report!

Could you create a minimal GitHub repo with a project which demonstrates this behaviour? :)

If you have that, I'm sure I can try to fix up the compilation-mode regexps to avoid this error.

Also: Please note this major-mode is getting superceded by typescript-ts-mode as part of Emacs 29 and newer 😄

JordanAnthonyKing commented 1 month ago

I'm aware it's getting superceded, but after it does what's happening to the extra integrations like this?

josteink commented 1 month ago

If it works, I see no reason not to add it to Emacs core 😉

josteink commented 1 month ago

Could you create a minimal GitHub repo with a project which demonstrates this behaviour? :)

Bump

JordanAnthonyKing commented 1 month ago

Sorry, I've been meaning to get around to this. Would it not be easier to just provide some standard messages and just run the regex against them?