define-advice causing issues in Emacs 24.4 and 24.5 - Githubissues

emacscollective / auto-compile

Automatically compile Emacs Lisp libraries

GNU General Public License v3.0

172 stars 16 forks source link

define-advice causing issues in Emacs 24.4 and 24.5 #19

Closed purcell closed 5 years ago

purcell commented 5 years ago

The recent change in advice seems to cause issues in 24.4 and 24.5, which I noticed because my emacs.d Travis build is failing on those versions with the following error:

Lisp error: (void-variable byte-compile-log-warning)
q\210T\211)$\207" [byte-compile-log-warning &optional _fill _level auto-compile auto-compile-file-buffer make-variable-buffer-local auto-compile-warnings define-advice :before _string "Increment local value of `auto-compile-warnings'."] 7)
  auto-compile-on-load-mode()

Newer versions are fine. Maybe define-advice was broken in those earlier nadvice versions?

tarsius commented 5 years ago

Turns out define-advice wasn't added until 25.1. Time to officially drop support for 24, I'm afraid.

purcell commented 5 years ago

Aww. You could just use advice-add, though, no?

purcell commented 5 years ago

Oh, I see - you mean that byte-compile-log-warning wasn't added until 25.1? That makes more sense.