emacscollective / borg

Assimilate Emacs packages as Git submodules
https://emacsmirror.net/manual/borg
GNU General Public License v3.0
255 stars 28 forks source link

Borg can't create the right autoloads file on Windows 10 #124

Closed Eason0210 closed 2 years ago

Eason0210 commented 2 years ago

Hi @tarsius

When I update Borg to the latest commit on Windows 10, I will got this error: It works well on macOS

File mode specification error: (user-error Local variables entry is missing the suffix)
$ make all
Initializing drones...done (92 drones in 0.662s)

--- [borg] ---

 Creating c:/Users/Eason/.emacs.d/lib/borg/borg-autoloads.el...
File mode specification error: (user-error Local variables entry is missing the suffix)
Compiling c:/Users/Eason/.emacs.d/lib/borg/borg-elpa.el...
Compiling c:/Users/Eason/.emacs.d/lib/borg/borg.el...
Done (Total of 2 files compiled)
  Running `makeinfo --no-split borg.texi -o borg.info'...
  Running `makeinfo --no-split borg.texi -o borg.info'...done
  Running `install-info borg.info --dir=dir'...
  Running `install-info borg.info --dir=dir'...done

With magit bitsect got this result:

5fe1113c70a116826734b2f5dfdb06247372a48f is the first bad commit
commit 5fe1113c70a116826734b2f5dfdb06247372a48f
Author: Jonas Bernoulli <jonas@bernoul.li>
Date:   Wed Apr 20 23:06:01 2022 +0200
    borg-maketexi: Fix previous commit
 borg.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

You can get this borg-autoloads.el I think it use the wrong coding system:

;; coding: utf-8-emacs-unix

When I roll back to commit 2cf5635, It works as expected and got this borg-autoloads.el

tarsius commented 2 years ago

It seems highly unlikely that this commit has anything to do with it.

A more likely candidate is 9e59c6476ef50e3b23cd984caf6722aeecff4c72.

Eason0210 commented 2 years ago

A more likely candidate is 9e59c64.

Yes, you are right.

I test it again on the commit before 9e59c64, It works well on 21acd89

tarsius commented 2 years ago

Check if dee07acd2064022e66e1c9317398418f14b9b839 helps.

Eason0210 commented 2 years ago

Check if dee07ac helps.

Now It works well with the latest commit. Thanks

tarsius commented 2 years ago

Thanks for the report!