Closed zyxir closed 1 year ago
When borg-remove is called before Magit is loaded, an error will occur:
borg-remove
Debugger entered--Lisp error: (void-function magit-git-version) magit-git-version() borg-drones() (progn (borg-drones))
I manage all my packages with Borg. In my opinion, Borg should work properly without Magit.
Make sure that Borg is installed in ~/.emacs.d/lib/borg. Launch Emacs with emacs -Q, and evaluate the code below:
~/.emacs.d/lib/borg
emacs -Q
(add-to-list 'load-path (expand-file-name "lib/borg" user-emacs-directory)) (require 'borg) (borg-drones)
This problem is caused by borg-drones explicitly calling magit-git-version without checking if Magit is available.
borg-drones
magit-git-version
My workaround is to add an :before advice to borg-remove, where Magit is required explicitly. However, I expect Borg to work without such workarounds.
:before
require
I think there should be alternative ways to get the Git version, without the help of Magit.
I've already fixed that pasto in the latest commit, but you might have to update borg manually.
borg
you might have to update borg manually.
Just did it. It fixed the issue. Thanks!
The Problem
When
borg-remove
is called before Magit is loaded, an error will occur:I manage all my packages with Borg. In my opinion, Borg should work properly without Magit.
Reproduce
Make sure that Borg is installed in
~/.emacs.d/lib/borg
. Launch Emacs withemacs -Q
, and evaluate the code below:Analysis
This problem is caused by
borg-drones
explicitly callingmagit-git-version
without checking if Magit is available.My workaround is to add an
:before
advice toborg-remove
, where Magit isrequire
d explicitly. However, I expect Borg to work without such workarounds.I think there should be alternative ways to get the Git version, without the help of Magit.