search

emacscollective / borg

Assimilate Emacs packages as Git submodules
https://emacsmirror.net/manual/borg
GNU General Public License v3.0
255 stars 28 forks source link

borg.drones-directory with a subfolder, encounter a file missing problem #144

Closed YanTree closed 2 weeks ago

YanTree commented 1 year ago

I confirm that...

I have read "Bootstrapping-from-scratch", I want to customize the variable of borg.drones-directory value, so used command below: git config --local borg.drones-directory "site-lisp/extensions/" But there was an unexpected error.

Steps to reproduce

  1. git config --local borg.drones-directory "site-lisp/extensions/"
  2. Makefile keep same from https://emacsmirror.net/manual/borg/Bootstrapping-from-scratch.html
  3. git submodule add --name borg git@github.com:emacscollective/borg.git site-lisp/extensions/borg
  4. make bootstrap
  5. Backtrace is shown in the figure below image

Environment

Emacs: 29.0.92 OS: Win11 22621.1992 Shell: powershell, gitbash

tarsius commented 1 year ago

Borg assumes that that directory is a direct subdirectory, at least when setting borg-drones-directory, borg-user-emacs-directory and borg-top-level-directory. Other code might make the same assumption.

Making that assumption makes things simpler, but it should be mentioned in the documentation.

Until now this assumption was not a problem -- it appears you are the first person who would like to use a more deeply nested directory. Is that really important to you? If so, you might have to implement for it yourself.

YanTree commented 1 year ago

All right, it's not so important to me. Until now I set borg.drones-directory to modules instead of a more deeply nested directory, it works perfectly!