search

emacscollective / epkg

Browse the Emacsmirror package database
https://emacsmirror.net/manual/epkg
GNU General Public License v3.0
55 stars 7 forks source link

No url found for submodule path 'epkgs/attic/breadcrumb' in .gitmodules #43

Closed daviderestivo closed 1 year ago

daviderestivo commented 1 year ago

Hi @tarsius,

since a week or so I noticed I have a problem in my CICD pipeline. The issue seems to be related to epkg:

Run git submodule init && git submodule update && git submodule foreach --recursive git checkout master
Submodule 'epkgs' (https://github.com/emacsmirror/epkgs.git) registered for path 'epkgs'
Submodule 'snippets' (https://github.com/AndreaCrotti/yasnippet-snippets.git) registered for path 'snippets'
Cloning into '/Users/runner/work/galactic-emacs/galactic-emacs/epkgs'...
Cloning into '/Users/runner/work/galactic-emacs/galactic-emacs/snippets'...
Submodule path 'epkgs': checked out '9d3aac7b39580e1263d02e296d36aa8712deee7d'
Submodule path 'snippets': checked out 'cd665c9cba4bab646f6d50ac098bee63573a4ca5'
Entering 'epkgs'
Previous HEAD position was 9d3aac7 Update metadata
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
fatal: No url found for submodule path 'epkgs/attic/breadcrumb' in .gitmodules
fatal: run_command returned non-zero status while recursing in the nested submodules of epkgs

Ref: https://github.com/daviderestivo/galactic-emacs/actions/runs/6155502786/job/16713361040

tarsius commented 1 year ago

The Emacsmirror now mirror a new implementation of that package, replacing an old implementation that was in the Emacsattic. See https://github.com/emacsmirror/epkgs/commit/146af56374a1309af870cb7d26eafff63c6dc356.

You'll probably have to add an extra step to your cicd pipeline that detects any modules that were remove in the epkgs repository and do the same locally before trying to update all modules.

daviderestivo commented 1 year ago

I'll have a look, thanks.

daviderestivo commented 1 year ago

@tarsius shouldn't you remove the folder 'epkgs/attic/breadcrumb' from https://github.com/emacsmirror/epkgs since breadcrumb has been moved to the epkgs/mirror/breadcrumb folder?

I know this is the wrong repo for such a request. If you like I can open another issue in https://github.com/emacsmirror/epkgs.

tarsius commented 1 year ago

I've removed it now. Don't know why it stuck around.