emacscollective / no-littering

Help keeping ~/.config/emacs clean
GNU General Public License v3.0
635 stars 69 forks source link

elgrep: theme elgrep-data-file #196

Closed xlmo closed 1 year ago

xlmo commented 1 year ago

Repos: https://github.com/TobiasZawada/elgrep This file is used to store an s-expression.

tarsius commented 1 year ago

Please note that the list of variables is sorted alphabetically, so don't just add new entries at the end. I have fixed this myself for this commit.

Usually when I do that, I push the result to the pull-request on the contributors fork, so that github recognizes when the commit is later merged into emacs. I couldn't do this in this case because you disallowed me to push to your fork. Also please do not use github to create commits. See the below links for more information on why I am asking you to do these things:

tarsius commented 1 year ago

Unfortunately this pull-request asks for your master branch to be merged into ours. It is better to use a dedicated feature branch instead, as explained here. It is too late for this pull-request now, but the next time you open a pull-request (in any repository really), then please use a feature branch.

This is a canned response; it may not apply 100% in this case.

tarsius commented 1 year ago

You have created this commit using Github, which sadly results in a corrupted commit. Please read this to learn why that happens and how to fix it.

This is a canned response; it may not apply 100% in this case.