search

emacscollective / no-littering

Help keeping ~/.config/emacs clean
GNU General Public License v3.0
635 stars 69 forks source link

gitignore: Exclude *-pkg.el #246

Closed gs-101 closed 3 weeks ago

gs-101 commented 3 weeks ago

Exclude "*-pkg.el" files. These are generated by the `:vc' keyword from use-package.

tarsius commented 3 weeks ago

Please instead add that to $XDG_CONFIG_HOME/git/ignore. Doing so will save you a lot of time because most package repositories don't have this in their .gitignore.

tarsius commented 3 weeks ago

I might merge this, but please don't take that as encouragement to open similar pull-request in my other repositories.

Like *-pkg.el, *.elc should IMO be ignored in the global ignore file, but over the years many users opened pull-requests like this one, so eventually I decided to just get it over with and add that to the .gitignore of all my packages.

But even if I end up deciding to do the same here, I want to do it on my own schedule, i.e., only when a package has other unreleased changes. I now release all packages monthly (or at least every other month), and I don't want to create releases just for this.

gs-101 commented 3 weeks ago

Please instead add that to $XDG_CONFIG_HOME/git/ignore.

Thank you, that seems to be a better idea (I didn't know about this, sorry about that).

I might merge this, but please don't take that as encouragement to open similar pull-request in my other repositories.

I'd say to not merge it and leave it closed as a sort of message or warning for other users. I'd recommend adding a section/line mentioning the global ignore configuration to your "contributions" pages instead, since users who are looking forward to contributing would check that first.

tarsius commented 3 weeks ago

I'd say to not merge it and leave it closed as a sort of message or warning for other users.

I'll close for now, but if I start getting as many requests for this as I got for *.elc and *-autoloads.el, then I'll add this rule too.

I'd recommend adding a section/line mentioning the global ignore configuration to your "contributions" pages instead, since users who are looking forward to contributing would check that first.

That too, I would have to add that to all my packages, some of which don't even have a "contributions page". Adding a note there would be more annoying than just adding the rule. (More annoying for everyone: me, users who wanted the rule added (and maybe still do), and users who couldn't care less but had to read about it anyway.)