search

emacscollective / no-littering

Help keeping ~/.config/emacs clean
GNU General Public License v3.0
635 stars 69 forks source link

auto-package-update: theme variables #83

Closed Guillawme closed 6 years ago

Guillawme commented 6 years ago

Repository for auto-package-update: https://github.com/rranelli/auto-package-update.el

Theme:

The variable ending in -path actually also points to the file. This file contains the timestamp of the last automatic package update.

Without this no-littering rule, auto-package-update will put this file in ~/.emacs.d/.last-package-update-day.

tarsius commented 6 years ago

See #59, #80, https://github.com/rranelli/auto-package-update.el/issues/31 and https://github.com/rranelli/auto-package-update.el/pull/32

Guillawme commented 6 years ago

Oops sorry, I should have done some research before submitting this. 😕 Next time I will check the PR history before submitting something.

Guillawme commented 6 years ago

Now that rranelli/auto-package-update.el#32 is merged, should we reopen this PR? I know you wanted the apu-* variables renamed with the same prefix as the rest of the package (auto-package-update), but as it is now that would already work ok.

I updated my fork accordingly, see Guilz/no-littering@a3f3955b82b7c47fbd39a7045897a2982ff203f0 but because this PR is closed it didn't pick up the new commit.

Guillawme commented 6 years ago

@tarsius would you be OK to merge this PR, now that rranelli/auto-package-update.el#36 is merged? (I think it addresses your main concern about naming user-exposed variables).