search

emacscollective / no-littering

Help keeping ~/.config/emacs clean
GNU General Public License v3.0
635 stars 69 forks source link

Theme `company-tabnine-binaries-folder`. #96

Closed cireu closed 5 years ago

cireu commented 5 years ago

This folder is used to hold the binaries of tabnine, the all language completer.

See https://github.com/TommyX12/company-tabnine/blob/master/company-tabnine.el#L202

tarsius commented 5 years ago

I've changed it to "company/tabnine-binaries" (plural).

Also what typo are you talking about in the commit message? I did not see any typo being fixed.

cireu commented 5 years ago

Done @tarsius

Also what typo are you talking about in the commit message? I did not see any typo being fixed.

Maybe I forget to clean the commit message after rebase.

tarsius commented 5 years ago

Thanks for providing the above link, that makes the initial review quicker to do. But it is not necessary to put that in the commit message, only the pull-request description. Line 202 will not forever point to the definition of this variable.