Mode support: Web-mode

[dieggsy]

This is mostly for consistency with html-mode, not necessarily what I think are optimal colors. Screenshot for comparison below, web-mode on left, html-mode on right. You'll notice tags are a little lighter, since in html-mode they inherit from font-lock-function-name-face but web-mode already has things that inherit from that face (function calls within <script>). Additionally, I made the doctype face a little different since it made no sense to me that it would inherit from font-lock-string-face. I barely ever edit html, so this is just what I gathered from the few documents I was working on at the moment.

Before:

After:

[dieggsy]

On second thought, the contrast is a little nicer when tags inherit from font-lock-function-name-face. What do you think?

[jasonm23]

I would prefer to go from Web mode as the primary theme and have nxml-mode and html-mode inherit from it or re-implement the same color selection.

I only use Web mode these days so it's what I am used to and prefer.

[jasonm23]

BTW, sorry I didn't respond sooner, I only just saw this as a notification and didn't see an email (although it probably slipped through on a mark all as read round).

[dieggsy]

I'm not sure I follow - right now web-mode support doesn't inherit from html-mode, I just tweaked it to be more consistent with html-mode's appearance. Are you saying you don't like the colors, or that we should find better colors for web-mode and have html inherit from it?

[jasonm23]

Sorry I forgot to follow up on this until now. I may tweak these color choices later. But LGTM.

[dieggsy]

Yeah, I'm thinking there may be too much blue (could make attrs orange?) and not enough contrast between tags and default text.

[jasonm23]

It's a work in progress :)