Add ERC support - Githubissues

emacsfodder / emacs-theme-darktooth

Darktooth : From the darkness... it watches.

GNU General Public License v3.0

319 stars 31 forks source link

Add ERC support #65

Closed galaunay closed 6 years ago

galaunay commented 6 years ago

Add support for ERC.

Some screenshots below:

Test in #darktooth channel
python channel (#emacs was merely empty that day):
For comparison, the #python channel before customization:

jasonm23 commented 6 years ago

LGTM! 👍 please resolve the rebase on master, and force push to your branch.

galaunay commented 6 years ago

Is it what you needed ?

Please note that I am not a ERC user for a long time, so some faces may not be optimal. I guess it is still a good first step.

jasonm23 commented 6 years ago

Thank you - just needed to fix the merge conflict.

dieggsy commented 6 years ago

Is there a missing parens one of these commits? M-x check-parens is showing Unmached bracket or quote on current master.

jasonm23 commented 6 years ago

Please fix. You'll have to submit a new pr if this isn't working. I'll roll the repo back

jasonm23 commented 6 years ago

It's rolled back.

I'm going to review.

jasonm23 commented 6 years ago

Pushed as 0.3.10 - ae14a9b

jasonm23 commented 6 years ago

FYI the FORM for autothemer-deftheme was closed at your eldoc theme definition, just an extra parenthesis.

Ironic since it was eldoc that allowed me to find the problem 🤓

jasonm23 commented 6 years ago

@galaunay & @dieggsy thanks for the help on getting ERC support added.

Glad it's now done 👍

galaunay commented 6 years ago

Sorry about the parenthesis. I went through the merging a little bit to fast I guess...

jasonm23 commented 6 years ago

Thank you @galaunay don't feel bad about it. I appreciate your help.