search

emacsfodder / emacs-theme-darktooth

Darktooth : From the darkness... it watches.
GNU General Public License v3.0
319 stars 31 forks source link

Add tab-bar and tab-line mode support (emacs 27) #72

Closed dalanicolai closed 3 years ago

jasonm23 commented 3 years ago

Thank you for your contribution.

Please provide a before and after screen shot in this conversation, to complete review and merge.

dalanicolai commented 3 years ago

So obviously it is about the tab bar at the top of the screen...

before Screenshot from 2020-12-12 16-27-32

after Screenshot from 2020-12-12 16-28-26

dieggsy commented 3 years ago

I think you might make the background same color as the mode-line or something like that so it's distinguishable?

dalanicolai commented 3 years ago

Yes true. But this is the before and after on my Spacemacs (using centaur-tabs)

before Screenshot from 2020-12-13 05-03-13

after Screenshot from 2020-12-13 05-01-38

As you can see, by default, the tabs take the color of the theme but the tab bar does not (I did not realize that this behavior is due to the Centaur tabs package.) So this PR makes it look much better.

You are free to choose a different color to make it distinguishable, but actually the tabs themselves are already a distinguishable color (in Spacemacs). For Emacs it is fine if the bar is indistinguishable, but you could give it a different color. But at least I do think that the theme should modify the color of the tab bar, instead of keeping it the default color.

jasonm23 commented 3 years ago

Thanks for the input @dieggsy

Appreciate the contribution @dalanicolai

Happy to merge.