search

emacsorphanage / dart-mode

An Emacs mode for the Dart language
GNU General Public License v3.0
15 stars 2 forks source link

dart-mode with lsp and flycheck #109

Closed zoechi closed 4 years ago

zoechi commented 4 years ago

When I try to enable the lsp checker I get

  lsp
    - major mode: `dart-mode' not supported
    - may enable: yes
    - predicate:  t

Flycheck cannot use this syntax checker for this buffer.

Flycheck Mode is enabled.  Use C-u C-c ! x to enable disabled
checkers.

--------------------

Flycheck version: 32snapshot (package: 20200318.319)
Emacs version:    28.0.50
System:           x86_64-pc-linux-gnu
Window system:    x

I also have dart-server installed.

Should this work that way?

zoechi commented 4 years ago

I get the same error for the dart-server-analysis-server checker.

bradyt commented 4 years ago

I could not reproduce your issue. Recipe for my test is here: https://github.com/bradyt/docker-emacs/tree/dart-mode-issue-109.

bradyt commented 4 years ago

Please note, this may have been better filed at lsp-mode. But it's hard to say since I cannot reproduce your issue.

Also, it seems I need to draft some sort of issue template. Ideas?

zoechi commented 4 years ago

Thanks for checking. Does installing dart-server still make sense with lsp-mode. I got the impression lsp-mode is kind of a replacement for dart-server or did I get this wrong?

zoechi commented 4 years ago

In case someone else runs into a similar issue. I got a response that led to a solution in https://github.com/flycheck/flycheck/issues/1693 No idea why I need this though.

bradyt commented 4 years ago

Thanks for checking. Does installing dart-server still make sense with lsp-mode. I got the impression lsp-mode is kind of a replacement for dart-server or did I get this wrong?

My impression is, many people are using an LSP mode, such as lsp-mode or eglot, instead of dart-server.el.

But I could imagine a hypothetical scenario, where, for whatever reason, one might be using one feature from dart-server.el, and another feature from lsp-mode. Say linting from dart-server, and jump-to-function from lsp-mode. But I would already wonder if, at least out of the box, that would increase RAM usage, by presumably creating a redundant dart process.