search

emacsorphanage / dart-mode

An Emacs mode for the Dart language
GNU General Public License v3.0
15 stars 2 forks source link

Jumpandcomplete #29

Closed sid-kurias closed 5 years ago

sid-kurias commented 8 years ago

Provide autocomplete support through company mode and jump to definition.

kondanta commented 5 years ago

@bradyt do you mind if I ask why don't you accept this PR? I mean, of course, there is a confliction(or more considering it's been open since 2016) like GitHub already stating but having auto-completion feature would be very nice.

bradyt commented 5 years ago

@kondanta, This pull request has been here since two years before I arrived at this project, about six months ago. I have not had time to research and test these commits. If I understand correctly, chronologically after these commits, completion was added to dart-mode. See https://github.com/bradyt/dart-mode#expansion. Unfortunately, there may be issues, see, https://github.com/bradyt/dart-mode/issues/77.

When I have time, I hope to research and understand how dart-mode interacts with the analysis server, so that I might help to ensure these features remain in working order. I would recommend lsp-mode, but completion (on C-M-i) took several seconds with that tool. Someone suggested to me that that time delay may be reduced after editing a file for extended periods, but I have not made time to test further.

Note that I disagree with some of the keybindings in dart-mode, I think M-/ should be left as users binding, often the lightweight dabbrev-expand, and if I understand correctly, heavier completion tools are often put on C-M-i, or interfaced through company, etc.

bradyt commented 5 years ago

Closing this issue. If someone wants to research these commits and find which parts are not already covered by dart-mode or lsp-mode, it would be helpful to bring those to our attention. If you can further, create branches for each topic that a portion of code is addressing, that would also be helpful.