search

emacsorphanage / git-gutter-fringe

Fringe version of git-gutter.el
160 stars 18 forks source link

"Match data clobbered by buffer modification hooks" #33

Open ivan-m opened 6 years ago

ivan-m commented 6 years ago

Seems to be the same issue as syl20bnr/emacs-emoji-cheat-sheet-plus#5: if I'm trying to do a large regexp-replace on my buffer, the first match succeeds and then I get the error message in the subject and regexp-replace fails.

GNU Emacs 25.3.1 (x86_64-apple-darwin16.6.0, NS appkit-1504.83 Version 10.12.5 (Build 16F73)) of 2017-10-10

haji-ali commented 4 years ago

While executing some commands (in my case, bibtex-reformat), I also get the error Match data clobbered by buffer modification hooks.

I chased down the reason and found that disabling git-gutter-mode resolves this issue. Looking further, the buffer had an overlay with a modification hook that executes fringe-helper-modification-func from the dependency fringe-helper. This function as can be seen here uses search-forward but without using save-match-data which I believe is what causes this issue.

The development of fringe-helper seems largely abandoned which is why I am reporting the issue here.