search

emacsorphanage / git-messenger

Emacs Port of git-messenger.vim
146 stars 14 forks source link

failed when using win64 emacs and cygwin svn #29

Closed redguardtoo closed 9 years ago

redguardtoo commented 9 years ago

I suggest giving user an extra chance to fix the path:

here is the my patch, https://github.com/redguardtoo/emacs.d/commit/ff7480a69cbbf6bd883bd62b05c6209e2d98fc82

here is sample usage from user side:

(setq git-messenger:fix-code-file-path-callback
      (lambda (file)
        (message "git-messenger:fix-code-file-path-callback called")
        (setenv "LANG" "")
        (if (string-match "^[cC]:/Workspaces/MAY_2015/" file)
            (setq file (replace-regexp-in-string
                        "^[cC]:/Workspaces/MAY_2015/"
                        "~/projs/lola/" file)))
        file))

tested on emacs24.4, windows, cygwin svn

syohex commented 9 years ago

git-messenger does not use full-path from #31.

redguardtoo commented 9 years ago

thanks, you solution is much cleaner.

another suggestion, reset env variable LANG before executing svn command and restore it after execution. looks cygwin svn has some issue. see attached screen shot. Git is fine.

bug

My locale is Australia English.

syohex commented 9 years ago

Environment variable LANG issue is fixed at #32.