Fix edit issue

[syohex]

This was introduced by #339.

Related issue

https://github.com/emacsorphanage/helm-ag/issues/218#issuecomment-692311439

[syohex]

@Namburgesas Could you review this patch as possible ?

[jcs090218]

Thanks! 😄

[Namburgesas]

Thank you @syohex for fixing my bugs. It would appear that data is stored differently for helm-do-ag-this-file compared with helm-dir-do-ag and others. I had tested the latter in #339 .

[Namburgesas]

Looks like the latter is actually the spacemacs function spacemacs/helm-dir-do-ag(I use spacemacs), which ends up calling helm-do-ag. I'll look into this.

[Namburgesas]

We're good to go 👍

Root cause:

• helm-do-ag-this-file -> helm-do-ag default-directory buffer-file-name Helm is configured with search-this-file=t. For a given file, this results in the same string object representing the filename for each matching line, which surfaced the missing puthash bug.

• spacemacs/helm-dir-do-ag -> helm-do-ag dir Helm is configured with search-this-file=nil. For a given file, this results in a new string object representing the filename for each matching line. (Probably due to Helm's implementation of searching across multiple files.) This, coupled with :test 'eql, hid the issue when using spacemacs/helm-dir-do-ag.