search

emacsorphanage / helm-ag

The silver searcher with helm interface
492 stars 76 forks source link

Start-file-process not working in emacs 29.1 #412

Open rakete opened 1 year ago

rakete commented 1 year ago

When I search for a pattern ag exits abnormally with signal 1 (I can see that by just printing the event in the process sentinel).

It should search the pattern I typed.

I am seeing this strange behaviour after upgrading to emacs 29.1 where when I use a list with string literals ag works fine, but as soon as I try to apply 'start-file-process to (cmd-args (helm-ag--construct-do-ag-command helm-pattern)) it stops working and ag exits with signal 1.

I can take the cmd-args and put them into the code like so:

(apply #'start-file-process "helm-do-ag" nil '("ag" "--no-color" "--nogroup" "helm"))

and it works, but as soon as I use helm-pattern instead of hardcoding the pattern it stops working.

So, cmd-args contains '("ag" "--no-color" "--nogroup" "helm") and ag fails, but if I hardcode that same list in the code it works.

Any ideas what could be the problem?

rakete commented 1 year ago

I've tried explicitly setting the shell to bash, tried using (format "%s" helm-pattern), but neither helped. I'll revert to emacs 28.2 for the time being since it works as expected there.