emacsorphanage / helm-swoop

Efficiently hopping squeezed lines powered by Emacs helm interface
GNU General Public License v3.0
689 stars 55 forks source link

Symbol's value as variable is void: helm-swoop-pattern #123

Closed kevinkwl closed 5 years ago

kevinkwl commented 6 years ago

macOS 10.13.1, emacs 25.3

helm-swoop does not work. Here's my config:

(use-package helm-swoop
  :ensure t
  :bind (("M-m" . helm-swoop)
     ("M-M" . helm-swoop-back-to-last-point))
  :init
  (bind-key "M-m" 'helm-swoop-from-isearch isearch-mode-map))

helm version:

helm-swoop         20170923.2127 installed   
prosoitos commented 6 years ago

One issue I had with helm-swoop is that it was unclear to me whether it was using regexp matching or not. For some patterns, it behaved as in a regexp search, while for others, it didn't. It was very hard for instance to look through my emacs init file or other files with key bindings and many special characters. helm-occur is very predictable and also allows fun things like every !thing to look for every* (everyone, everywhere, everybody, etc.) but not everything for instance. I truly was a fan of helm-swoop until the recent events. But I am now a totally converted helm fan :D

And for the speed, I don't know what to say. helm-swoop, in my settings, was struggling to search in the list-packages buffer for instance. While helm-occur is much smoother for me there. But that might depend on settings, etc.

At the end of the day, if nobody takes over the project, it doesn't matter whether the patch gets applied or not as some other helm update will break it again. With helm doing something so very similar and being actively developed and maintained, that is is not looking good for helm-swoop. So regardless of personal preferences over details, it might just be more practical in the long run to switch over. And that's why I was trying to help others with my posts.

xuchengpeng commented 6 years ago

@it3ration patch test ok

(use-package helm-swoop
  :ensure t
  :load-path "site-lisp/helm-swoop"
wusticality commented 6 years ago

@xuchengpeng ?

cireu commented 5 years ago

This is fixed in master, please test.