Closed jguenther closed 6 years ago
OK once I updated helm-core this patch works for me in fixing #123. Does it need to detect which version of helm is installed to stay compatible with melpa-stable?
@stsquad the new arg is &optional
, should be OK on older helm versions.
@ShingoFukuyama anything I can do to help get this merged?
@ShingoFukuyama Oh, lord, just merge this PR
Thank you @jguenther and everyone here for tackling the issue! And I'm sorry for this very late notice... I'll close this pull request due to #125
I believe this fixes #123
After manually declaring the
helm-swoop-pattern
variable as buffer-local, I was getting an error fromhelm-display-buffer()
:Looks like the underlying problem is due to 97020d189f in helm. The
helm-display-buffer
function now calls thehelm-display-function
with an additional optional arg (RESUME
).This PR changes
helm-swoop-split-window-function
into adefcustom
, and split out the old default lambda value into the functionhelm-swoop--split-window-default
.~I'm unsure if using
defvar-local
is the right thing to do forhelm-swoop-pattern
et al, but it seems to work for me.~edit: this fix actually works without
defvar-local
, I'll remove that commit.