search

emacsorphanage / helm-swoop

Efficiently hopping squeezed lines powered by Emacs helm interface
GNU General Public License v3.0
689 stars 55 forks source link

Make the highlight threshold customizable #142

Closed sfavazza closed 5 years ago

sfavazza commented 5 years ago

This would fix the issue #131. The default value is left as in the original implementation. Then the user can simply customize the minimum pattern length to trigger the match highlighting.

Ex:

;; highlight a text from the first matched character
(setq helm-swoop-min-overlay-length 0)
cireu commented 5 years ago

I made highlight function customizable in this PR. https://github.com/emacsorphanage/helm-swoop/pull/146

cireu commented 5 years ago

Hello, please check #146, customize highlight function is available now. @sfavazza

cireu commented 5 years ago

Sorry for closing your PR hastily, #146 means customizable highlight function, your PR means customizable highlight threshold. I' ll consider it again.

cireu commented 5 years ago

LGTM, please review @conao3

conao3 commented 5 years ago

I'll test soon. Please wait for a moment.

conao3 commented 5 years ago

LGTM. Thank you for PR! Congrats on your first contribution! 🎉

sfavazza commented 5 years ago

Actually I was wondering how the mentioned commit was supposed to address my issue :sweat_smile: But really thanks for your reconsideration! You made my day guys!