search

emacsorphanage / helm-swoop

Efficiently hopping squeezed lines powered by Emacs helm interface
GNU General Public License v3.0
689 stars 55 forks source link

Quick fix to `helm-swoop` #145

Closed cireu closed 5 years ago

cireu commented 5 years ago

Close https://github.com/emacsorphanage/helm-swoop/issues/133 https://github.com/emacsorphanage/helm-swoop/issues/123

Clean byte-compiler warnings

Update dependency helm to 3.2

cireu commented 5 years ago

@JesusMtnez @conao3 Do you interested in review this PR?

conao3 commented 5 years ago

OK.

Related to 881c535, I think this repository have be maintained by emacsorphanage. It would be undesirable to write the name of an individual. We should be involved in this package as part of the organization.

I am not familiar with helm, so I say just looks good to me.

cireu commented 5 years ago

@conao3 I edit the copyright from my name to Emacsorphanage, but I'd like to keep the Maintainer line because Github orgnization doesn't seems to have an email address.

conao3 commented 5 years ago

I think it is not desirable to keep the maintainer line. In fact, the change is not directly related to this PR. You should first delete that line and discuss with @tarsius in another issue what we prefer to write about the maintainer line.

With at least four people (@tarsius, @cireu, @JesusMtnez, @conao3) expected to have maintenance authority, I don't agree with writing one maintainer line per one person to add nonessential information.

cireu commented 5 years ago

Ok, I remove the assignment commit until we draw the conclusion of https://github.com/melpa/melpa/issues/6347 @conao3