Open conao3 opened 5 years ago
IMO, they shouldn't use advice at all, advice just an adhoc solution for modify function in other packages without touch their source code. Using specific keymap would be better.
Please have a look at https://github.com/emacsorphanage/helm-swoop/pull/150
Maybe we can get some inspiration from https://github.com/emacs-helm/helm/blob/master/helm-occur.el#L301
Close in https://github.com/emacsorphanage/helm-swoop/pull/150
@conao3 AFIAK, you can add magick word Close #xxx
in the merge commit and Github will close corresponded issue automatically.
I know, but there are still remained another defadvice
don't you?
Nowadays, advice with
defadvice
is not a good choice. So we should rewrite all advice functions withnadvice
.