search

emacsorphanage / helm-swoop

Efficiently hopping squeezed lines powered by Emacs helm interface
GNU General Public License v3.0
689 stars 55 forks source link

Add git-hook script, Makefile, CONTRIBUTING.org #153

Closed conao3 closed 4 years ago

conao3 commented 5 years ago

This solves your suggestion in #152. And add docker testing environment with Emacs-24.4 to Emacs 26.2. (With writing this PR, I found this package does not work in Emacs-24.3. This issue should also be solved.)

cireu commented 5 years ago

Why not use Cask? Cask can manage dependency automatically, and cask also support fetch library from github(for cort-test.el)

conao3 commented 5 years ago

Cask is not required. Our only purpose is to fetch and unpack a few packages with curl and tar, for which the Cask is overspec.

But I'm interested in how much easier it is to use Cask. If you have time, please rewrite it. I have never used Cask and I have no intention of using it.

conao3 commented 4 years ago

CC @rejeep (a member of cask)

A month has passed. Anyway, we need a test environment. Even if we can't write enough test cases, it's better than just making sure we can compile without errors or warnings. I want to run Emacs tests with multiple versions in Docker. We already have a Makefile for that, but if Cask simplifies that flow, I'll be interested in it.

Is it possible to simplify with Cask what I am requesting?

P.S. If @rejeep have time, please tell us about multi-version testing at cask? I currently have dockerize Emacs, but other solutions are possible if we are easy to prepare and provide a completely separate test environment.

conao3 commented 4 years ago

Close because #170 merged.