search

emacsorphanage / helm-swoop

Efficiently hopping squeezed lines powered by Emacs helm interface
GNU General Public License v3.0
689 stars 55 forks source link

Bump dependencies and release 2.0.0 #154

Closed conao3 closed 5 years ago

conao3 commented 5 years ago

helm-swoop can't byte-compile with Emacs-24.3

In toplevel form:
helm-swoop.el:90:1:Error: Symbol's function definition is void: advice-add
make: *** [helm-swoop.elc] Error 1
cireu commented 5 years ago

Please be patient, I'd like to bump helm to 3.2 and release 2.0.0 with drop support of Emacs 24.3 together ;)

conao3 commented 5 years ago

Yes, I agree with it.

conao3 commented 5 years ago

Notice: I bump to version 2.0.0 in code but MELPA stable still distributes v1.7.4. We tag this commit after more testing this version.

conao3 commented 5 years ago

Do you think this PR needs discussion? In my opinion, the wrong version of helm is a bug, and I think it should be fixed as soon as possible.

In fact, this is what we got back to when you reverted all of your PR #145 when #148. Create another PR if necessary, how do you think?

cireu commented 5 years ago

Can you help clean all byte-compiler warnings in helm-swoop.el? Just like https://github.com/emacsorphanage/helm-swoop/commit/7fcb4013da3bf956715ea19996b62be10ef9b386

And we can bump version to 2.0.0 after clean all warnings.

No need to a new branch, do it here is OK.

conao3 commented 5 years ago

I Cherry-pick that commit.

cireu commented 5 years ago

I squash them and merge.