search

emacsorphanage / helm-swoop

Efficiently hopping squeezed lines powered by Emacs helm interface
GNU General Public License v3.0
689 stars 55 forks source link

Enhance line number's UX #157

Open conao3 opened 5 years ago

conao3 commented 5 years ago

Re #113.

@conao3 Yes, feel free to close this PR, as I don't intend to work on it anymore. If I may, I'd recommend rewriting the line numbers to use text-properties to store and retrieve them, and perhaps using overlays to optionally display them. I think that will improve performance and flexibility.

cireu commented 5 years ago

Not only make it optional, current line number implementation has awful User Experience.

  1. Any regex that matching a digit will match line number. Mentioned in https://github.com/emacsorphanage/helm-swoop/issues/45

  2. Misalignment, old implementation simply add one space after line number, so the swoop buffer will look like

图片

I had made some changes in https://github.com/cireu/helm-swoop fix issues I mentioned above. But I still need some time to test and merge them.

cireu commented 5 years ago

and perhaps using overlays to optionally display them.

Can overlays be put on empty lines? @alphapapa