Remove dollar symbol from local variable

emacsorphanage / helm-swoop

Efficiently hopping squeezed lines powered by Emacs helm interface

GNU General Public License v3.0

689 stars 55 forks source link

Closed conao3 closed 4 years ago

conao3 commented 4 years ago

Remove dollar symbol from local variable.

This PR makes flycheck's warnings 79 to 47.

conao3 commented 4 years ago

Merge for now. if occur any issues, please revert it.

ymd-h commented 4 years ago

This PR intended to change only local variables, but changed public API of helm-swoop , too. (here)

Libraries depanding helm-swoop can be broken. (e.g. ace-isearch has been broken and there is an unmarged PR.)

I had a problem with "helm-swoop-20200321.231" and "ace-isearch-20200205.1105"

conao3 commented 4 years ago

I knew that problem would happen, so please encourage the ace-isearch maintainers to merge the PR.