search

emacsorphanage / helm-swoop

Efficiently hopping squeezed lines powered by Emacs helm interface
GNU General Public License v3.0
688 stars 55 forks source link

Add "ext:" to declare-function invocations. #183

Closed leungbk closed 4 years ago

leungbk commented 4 years ago

Per the docstring for declare-function, functions not part of core Emacs should have "ext:" in their declare-function invocations.

conao3 commented 4 years ago

Yes, I know. But did that harm anything? Did something break?

leungbk commented 4 years ago

(check-declare-file "/home/me/helm-swoop.el") throws a warning when the "ext:"s aren't there and you're missing either projectile or migemo. But otherwise there are no problems.

On Sun, May 10, 2020 at 11:17 AM Naoya Yamashita notifications@github.com wrote:

Yes, I know. But did that harm anything? Did something break?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/emacsorphanage/helm-swoop/pull/183#issuecomment-626367720, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG65GOTUWI4YDTCGEZ532FTRQ3VS5ANCNFSM4M5LBRTQ .

conao3 commented 4 years ago

As that broke nothing, I think it's common not to put ext: on it. How about @cireu ?

cireu commented 4 years ago

As that broke nothing, I think it's common not to put ext: on it. How about @cireu ?

Search my site-lisp folder with pattern (declare-function ext:, 135 results(I have about 100 plugins in it).

Notice that helm / projectile / ivy use this format. So I think we may follow up.

conao3 commented 4 years ago

OK, I think so too now. I'll merge it.