search

emacsorphanage / helm-swoop

Efficiently hopping squeezed lines powered by Emacs helm interface
GNU General Public License v3.0
688 stars 55 forks source link

What would it take to support searching newlines? #203

Open robert-e-davidson3 opened 2 years ago

robert-e-davidson3 commented 2 years ago

I get an error when I select a region with multiple lines and try to search it. The source code makes it clear this is intentional but doesn't explain why. Also, when I add a newline with c-q c-j, it behaves strangely.

I can't find anything about why multiple lines are unsupported for search. The builtin isearch works but there's a reason I use helm-swoop.

Is there some deep reason this is unsupported? If not, can I get some guidance? I'm willing to make the changes myself if it isn't an immense effort.

Thanks!

alphapapa commented 2 years ago

@robert-e-davidson3 FYI, if you want to work on something like this, you might consider using this as a starting point instead of helm-swoop: https://gist.github.com/alphapapa/ce6cf8a85d8a28c3a2f146057772ec8d IME it's much faster (although because of that, I stopped using helm-swoop years ago, so maybe it's improved since then).