swoop window isn't properly managed by shackle/popwin

emacsorphanage / helm-swoop

Efficiently hopping squeezed lines powered by Emacs helm interface

GNU General Public License v3.0

689 stars 55 forks source link

swoop window isn't properly managed by shackle/popwin #62

Open nivekuil opened 9 years ago

nivekuil commented 9 years ago

I tried to use shackle to get helm-swoop to appear as a popup above the minibuffer, but it only works when using swoop in the last (rightmost) window. The issue seems to be with helm-swoop-split-window-function, which doesn't use display-buffer, unlike other helm interfaces. Changing it to

(defvar helm-swoop-split-window-function
  (lambda ($buf)
    (display-buffer $buf)))

seems to be enough to make it properly hand the display over to helm/shackle.

wpcarro commented 7 years ago

@nivekuil Thanks for sharing this. It seems to solve some of the problems I'm experiencing with helm-swoop and shackle/popwin.

Have you observed the bug that searching with a vertical split jumps the cursor to the correct lines in the wrong file? Frustrating because I enjoy the shackle/popwin appearance.