search

emacsorphanage / macrostep

interactive macro-expander for Emacs
GNU General Public License v3.0
15 stars 6 forks source link

Fix keymap #5

Closed abougouffa closed 1 year ago

abougouffa commented 1 year ago

This fixes the issue #4

It turned out that the keymap is not bound the macrostep-mode

abougouffa commented 1 year ago

The bug seems to be introduced in c20f621bf2651aaf0f5c3e910b672ae859ebf126

seagle0128 commented 1 year ago

Any update for this, please?

PhilHudson commented 1 year ago

Pending a fix, in case anyone else is caught out by this, some will have worked it out but it's good to be explicit: M-x macrostep-collapse-all still works instead of q.

ska80 commented 1 year ago

@tarsius @skangas Could you please, apply this fix? Thanks!

tarsius commented 1 year ago

For some reason I was not subscribed. I'll have a look tomorrow.

tarsius commented 1 year ago

I've instead applied Stefan's patch, which renames the keymap to the correct name, define-minor-mode then pics it up automatically.